Take security patch #414
Merged
Take security patch #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
previously approved these changes
Sep 9, 2024
ecordell
reviewed
Sep 12, 2024
ecordell
reviewed
Sep 13, 2024
internal/storage/secrets.go
Outdated
| if err != nil { | ||
| return "", err | ||
| } | ||
| b, err := term.ReadPassword(intFd) |
There was a problem hiding this comment.
I found https://pkg.go.dev/github.com/charmbracelet/x/term which takes a uintptr for ReadPassword too
ecordell
previously approved these changes
Sep 13, 2024
ecordell
reviewed
Sep 13, 2024
.goreleaser.yml
Outdated
| @@ -118,10 +118,6 @@ nfpms: | |||
| builds: ["linux-amd64-musl", "linux-arm64-musl"] | |||
| formats: ["apk"] | |||
|
|
|||
| furies: | |||
There was a problem hiding this comment.
do we not push to gemfury now?
There was a problem hiding this comment.
It's marked as invalid by goreleaser, but it's in their documentation...
Wha?
There was a problem hiding this comment.
I'll reinstate it and raise another issue.
|
I created an issue on goreleaser for the v2.3.0 regression: goreleaser/goreleaser#5138 |
ecordell
approved these changes
Sep 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.22.7 published a security patch. This takes that patch.
Changes
Bump go.mod to take patch and fix subsequent lint issues
Testing
Review.